Mark enum constants in signal.py as Final, not Literal
#13500
+47
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
|
The change basically LGTM, but pytype is crashing. Also, pyright has quite different inference for generic parameters compared to mypy, so I think we'll struggle to find a test case test demonstrates the issue clearly while passing on both mypy and pyright. I'd be tempted to just skip the test case, personally. |
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
|
Any ideas on what's wrong? |
|
looks like a pytype bug to me |
|
cc @rchen152 |
|
I don't work on pytype anymore, either. Maybe @h-joo? |
Oh, sorry! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #13336 caused a regression in mypy, see python/mypy#18628
So, I changed
LiteraltoFinal, since it works and added a test case for the regression.